Files
oxipy/oxi/interfaces/base.py
IluaAir 685ff19d2f Enhance BaseDevice validation and update Mikrotik model
- Introduced a new method `_validate_template_groups` in `BaseDevice` to ensure TTP templates declare all required and optional sections.
- Updated `_REQUIRED_SECTIONS` and added `_OPTIONAL_SECTIONS` to improve template validation.
- Modified the `vlans` method in `Mikrotik` to streamline raw data handling and added debug print statements for clarity.
- Revised the Mikrotik TTP template to include structured variable definitions and improved group handling for interfaces and VLANs.
2026-02-19 00:16:37 +03:00

117 lines
3.9 KiB
Python

from abc import ABC, abstractmethod
from pathlib import Path
from typing import TYPE_CHECKING
from ttp import ttp
from oxi.interfaces.contract import Device
import xml.etree.ElementTree as ET
if TYPE_CHECKING:
from oxi.interfaces.contract import Interfaces, System, Vlans
class BaseDevice(ABC):
_REQUIRED_SECTIONS: frozenset[str] = frozenset({"system", "interfaces"})
_OPTIONAL_SECTIONS: frozenset[str] = frozenset({"vlans"})
def __init__(self, config: str):
self.config: str = config
self._loaded_template = self._load_template()
self._validate_template_groups()
self._raw: dict = self._run_ttp()
@property
@abstractmethod
def template(self) -> str:
"""
:return:
"""
@abstractmethod
def vlans(self) -> list["Vlans"]:
f"""
Parse VLAN configuration from self._raw['vlans'].
Expected raw structure:
[{"id": 10, "description": "MGMT"}, {"id": 15, "name": "SSH"}, ...]
Returns:
list[Vlans]: список VLAN из секции vlans,
пустой список если секция отсутствует.
Raises:
ValueError: если _raw содержит некорректные данные.
"""
...
@abstractmethod
def interfaces(self) -> list["Interfaces"]:
f"""
Parse Interface configuration from self._raw['interfaces'].
Expected raw structure:
[{"name": "GEthernet1/0/1", "ip_address": "192.168.1.1", "mask": "24", "description": "IPBB interface"}]
Raises:
ValueError: если _raw содержит некорректные данные.
"""
...
@abstractmethod
def system(self) -> "System":
"""
Parse System configuration from self._raw['system'].
Expected raw structure:
{"model":"RB951Ui-2nD", serial_number: "B88C0B31117B", "version": "7.12.1"}
Raises:
ValueError: если _raw содержит некорректные данные.
"""
...
def _load_template(self):
path = Path(__file__).parent / "models" / "templates" / self.template
if not path.exists():
print("-" * 12)
print(path)
raise FileNotFoundError(f"Template {self.template} not found")
return path.read_text(encoding="utf-8")
def _validate_template_groups(self) -> None:
"""Проверка что TTP темлпейт имеет декларированные группы для всех требуемых и опциональных секций"""
try:
root = ET.fromstring(self._loaded_template)
except ET.ParseError:
root = ET.fromstring(f"<template>{self._loaded_template}</template>")
declared = {g.get("name") for g in root.iter("group") if g.get("name")}
expected = self._REQUIRED_SECTIONS | self._OPTIONAL_SECTIONS
missing = expected - declared
if missing:
raise ValueError(
f"{self.__class__.__name__}: template '{self.template}' "
f"missing group declarations: {sorted(missing)}. "
f"Declared groups: {sorted(declared)}"
)
def _run_ttp(self) -> dict:
p = ttp(data=self.config, template=self._loaded_template)
p.parse()
raw: dict = p.result()[0][0]
missing = self._REQUIRED_SECTIONS - raw.keys()
if missing:
raise ValueError(
f"{self.__class__.__name__}: TTP template '{self.template}' "
f"did not produce required sections: {sorted(missing)}. "
f"Got: {sorted(raw.keys())}"
)
return raw
def parse(self) -> Device:
return Device(
system=self.system(),
interfaces=self.interfaces(),
vlans=self.vlans(),
)